Re: [PATCH v2 -mm 9/9] netconsole: Support dynamic reconfiguration using configfs

[Keiichi KII <k-keiichi@bx.jp.nec.com>]

Hi Satyam,

>  struct netconsole_target {
>  	struct list_head	list;
> +#ifdef	CONFIG_NETCONSOLE_DYNAMIC
> +	struct config_item	item;
> +	int			enabled;
> +#endif
>  	struct netpoll		np;
>  };

If CONFIG_NETCONSOLE_DYNAMIC is unset, we can't access to the "enabled" member.
So, the compile errors occur because the following functions make use of 
the above one.

> +/* Allocate new target (from boot/module param) and setup netpoll for it */
> +static struct netconsole_target *alloc_param_target(char *target_config)
>  {
>  	int err = -ENOMEM;
>  	struct netconsole_target *nt;
>  
> -	/* Allocate and initialize with defaults */
> +	/*
> +	 * Allocate and initialize with defaults.
> +	 * Note that these targets get their config_item fields zeroed-out.
> +	 */
>  	nt = kzalloc(sizeof(*nt), GFP_KERNEL);
>  	if (!nt) {
>  		printk(KERN_ERR "netconsole: failed to allocate memory\n");
> @@ -106,6 +188,8 @@ static struct netconsole_target *alloc_t
>  	if (err)
>  		goto fail;
>  
> +	nt->enabled = 1;
> +
>  	return nt;
>  
>  fail:
> @@ -113,13 +197,469 @@ fail:
>  	return ERR_PTR(err);
>  }


> @@ -169,7 +711,8 @@ static void write_msg(struct console *co
>  
>  	spin_lock_irqsave(&target_list_lock, flags);
>  	list_for_each_entry(nt, &target_list, list) {
> -		if (netif_running(nt->np.dev)) {
> +		netconsole_target_get(nt);
> +		if (nt->enabled && netif_running(nt->np.dev)) {
>  			/*
>  			 * We nest this inside the for-each-target loop above
>  			 * so that we're able to get as much logging out to
> @@ -184,6 +727,7 @@ static void write_msg(struct console *co
>  				left -= frag;
>  			}
>  		}
> +		netconsole_target_put(nt);
>  	}
>  	spin_unlock_irqrestore(&target_list_lock, flags);
>  }

I created the following patch for performing some tests.
If there is nothing wrong with the patch, I'm going to continue to test.

Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>

Index: mm/drivers/net/netconsole.c
===================================================================
--- mm.orig/drivers/net/netconsole.c
+++ mm/drivers/net/netconsole.c
@@ -94,8 +94,8 @@ struct netconsole_target {
        struct list_head        list;
 #ifdef CONFIG_NETCONSOLE_DYNAMIC
        struct config_item      item;
-       int                     enabled;
 #endif
+       int                     enabled;
        struct netpoll          np;
 };


Thanks
-- 
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: k-keiichi@bx.jp.nec.com