From: Brian King <brking@linux.vnet.ibm.com>
To: "Prakash, Sathya" <sathya.prakash@lsi.com>
Cc: linux-scsi@vger.kernel.org, eric.moore@lsi.com
Subject: Re: [PATCH] mpt fusion: add sysfs attributes to display IOC parameters
Date: Thu, 12 Jul 2007 09:12:29 -0500 [thread overview]
Message-ID: <469636CD.8000902@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070712082230.GA27605@lsil.com>
Prakash, Sathya wrote:
> +static ssize_t
> +mptscsih_version_driver_show(struct class_device *cdev, char *buf)
> +{
> + return snprintf(buf, PAGE_SIZE, "%s\n", MPT_LINUX_VERSION_COMMON);
> +}
> +static CLASS_DEVICE_ATTR(version_driver, S_IRUGO, mptscsih_version_driver_show, NULL);
This should be removed from the patch. This information is already
available in sysfs: /sys/module/mptscsih/version
-Brian
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
next prev parent reply other threads:[~2007-07-12 14:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 8:22 [PATCH] mpt fusion: add sysfs attributes to display IOC parameters Prakash, Sathya
2007-07-12 14:12 ` Brian King [this message]
2007-07-12 16:30 ` Moore, Eric
[not found] <20070713041041.GA5149@lsil.com>
2007-07-13 17:12 ` Moore, Eric
2007-07-17 9:09 ` Prakash, Sathya
2007-07-17 16:56 ` Moore, Eric
-- strict thread matches above, loose matches on Subject: below --
2007-07-03 13:01 [PATCH]mpt " Prakash, Sathya
2007-07-03 13:49 ` Brian King
2007-07-03 17:19 ` Patrick_Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469636CD.8000902@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=eric.moore@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.