From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Dong, Eddie" <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: rebase hlt emulation
Date: Thu, 12 Jul 2007 18:00:15 +0300 [thread overview]
Message-ID: <469641FF.2090408@qumranet.com> (raw)
In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01C24C36-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Dong, Eddie wrote:
> Gregory Haskins wrote:
>
>> On Thu, 2007-07-12 at 22:20 +0800, Dong, Eddie wrote:
>>
>>
>>
>>> Apply to current kvm.git? Then we need to define false for
>>> irqchip_in_kernel() which makes the patch quit stranger.
>>>
>> I think what Avi is saying is this can be generalized as a separate
>> feature independent of in-kernel-PIC. Since Avi and I are both
>> advocating a separate capability for in-kernel-HLT, you
>> wouldn't need to
>> have a stubbed irqchip_in_kernel. Rather, you should have a flag that
>> indicates whether userspace enabled the HLT capability or not.
>>
>
> Then Avi need to check in your patch in user level to remove the race
> condition, otherwise
> the patch does nothing and just some dead code.
>
> Avi:
> Can u have a double check to see what you want to do. I am fine
> with either of them.
>
Like Gregory said: we check in the hlt patch to the kernel, and the race
removal + use the new feature patch for userspace.
Gregory, can you repost that patch please? Eddie, please test both with
and without the userspace patch.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-12 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 14:45 rebase hlt emulation Gregory Haskins
[not found] ` <4696065E0200005A0002766F-Igcdv/6uVdMHoYOw/+koYqIwWpluYiW7@public.gmane.org>
2007-07-12 14:54 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01C24C36-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-07-12 15:00 ` Avi Kivity [this message]
[not found] ` <469641FF.2090408-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-12 15:34 ` Dong, Eddie
-- strict thread matches above, loose matches on Subject: below --
2007-07-12 9:31 Gregory Haskins
[not found] ` <4695BCA50200005A000275FE-Igcdv/6uVdMHoYOw/+koYqIwWpluYiW7@public.gmane.org>
2007-07-12 9:53 ` Avi Kivity
2007-07-07 4:42 Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01B8F3F3-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-07-12 5:33 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01C249B6-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-07-12 9:51 ` Avi Kivity
[not found] ` <4695F9BF.9000301-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-12 14:20 ` Dong, Eddie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469641FF.2090408@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.