From: Ben Guthro <bguthro@virtualiron.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] Stop clobbering AMD TSC offsets
Date: Thu, 12 Jul 2007 16:50:46 -0400 [thread overview]
Message-ID: <46969426.6030600@virtualiron.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
This fixes a bug in which HVM VCPUs running on AMD have their TSC
offset clobbered (to zero) when they switch to real mode. The
consequences of this are nearly unnoticeable in most cases, but the
AMD folks (Tom Woller & Travis Betak) agree this is a (minor) bug and
have been waiting forever for me to port and post this so they can
strike it off their TODO lists.
Signed-off-by: David Lively <dlively@virtualiron.com>
Signed-off-by: Ben Guthro <bguthro@virtualiron.com>
[-- Attachment #2: amd-stop-clobbering-tsc-offset.patch --]
[-- Type: text/x-patch, Size: 516 bytes --]
diff -r c03c4be32469 xen/arch/x86/hvm/svm/svm.c
--- a/xen/arch/x86/hvm/svm/svm.c Thu Jul 12 14:31:51 2007 -0400
+++ b/xen/arch/x86/hvm/svm/svm.c Thu Jul 12 14:31:51 2007 -0400
@@ -2329,9 +2329,6 @@ static int svm_reset_to_realmode(struct
/* clear the vmcb and user regs */
memset(regs, 0, sizeof(struct cpu_user_regs));
- /* VMCB Control */
- vmcb->tsc_offset = 0;
-
/* VMCB State */
vmcb->cr0 = X86_CR0_ET | X86_CR0_PG | X86_CR0_WP;
v->arch.hvm_svm.cpu_shadow_cr0 = X86_CR0_ET;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
reply other threads:[~2007-07-12 20:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46969426.6030600@virtualiron.com \
--to=bguthro@virtualiron.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.