From: Tejun Heo <htejun@gmail.com>
To: albertl@mail.com
Cc: Jeff Garzik <jeff@garzik.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Doug Maxey <dwm@enoyolf.org>,
Mark Lord <mlord@pobox.com>,
Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 5/7] libata: integrate freeze/thaw with irq_on/off
Date: Fri, 13 Jul 2007 15:51:29 +0900 [thread overview]
Message-ID: <469720F1.3000907@gmail.com> (raw)
In-Reply-To: <468F3CE2.9080709@tw.ibm.com>
Hello,
> +void ata_irq_on(struct ata_port *ap)
> {
> struct ata_ioports *ioaddr = &ap->ioaddr;
> - u8 tmp;
>
> ap->ctl &= ~ATA_NIEN;
> ap->last_ctl = ap->ctl;
>
> iowrite8(ap->ctl, ioaddr->ctl_addr);
> - tmp = ata_wait_idle(ap);
> + ata_wait_idle(ap);
>
> ap->ops->irq_clear(ap);
> -
> - return tmp;
> }
Missing ata_chk_status() before clearing ATA_NIEN seems a bit dangerous
to me.
--
tejun
next prev parent reply other threads:[~2007-07-13 6:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 6:57 [PATCH 0/7] libata: irq_on/off restructuring (take #2) Albert Lee
2007-07-07 7:00 ` [PATCH 1/7] libata: remove irq_on from ata_bus_reset() and ata_std_postreset() Albert Lee
2007-07-12 20:12 ` Jeff Garzik
2007-07-07 7:02 ` [PATCH 2/7] sata_promise: pdc_freeze() semantic change Albert Lee
2007-10-02 15:28 ` Jeff Garzik
2007-07-07 7:05 ` [PATCH 3/7] libata: add freeze/thaw to old EH LLDDs Albert Lee
2007-07-07 7:09 ` [PATCH 4/7] libata: use freeze/thaw for polling PIO Albert Lee
2007-07-13 6:53 ` Tejun Heo
2007-07-07 7:12 ` [PATCH 5/7] libata: integrate freeze/thaw with irq_on/off Albert Lee
2007-07-13 6:51 ` Tejun Heo [this message]
2007-07-16 9:17 ` Albert Lee
2007-07-07 7:20 ` [PATCH 6/7] libata: remove nIEN handling from ata_tf_load() Albert Lee
2007-07-07 7:23 ` [PATCH 7/7] libata: remove ap->last_ctl Albert Lee
2007-07-13 6:58 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469720F1.3000907@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=dwm@enoyolf.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.