Re: Always zero test in arch/i386/pci/mmconfig-shared.c

[Scott Ashcroft <scott.ashcroft@talk21.com>]

Robert Hancock wrote:
  > You missed this code:
> 
> name = pci_mmcfg_probes[i].probe();
> 
> This calls one of the probe functions above, which will set 
> pci_mmcfg_config_num to something else, as with the name variable. It 
> may set the name but not the config num, if the chipset is recognized 
> but MMCONFIG isn't enabled, etc.

Obvious now you've pointed it out. Bit of of a weird way to do things.
I might brew up a patch which adds the names to the 
pci_mmcfg_hostbridge_probe struct, since they appear to be always 
returned if the probe function is called, and make the probe functions 
return the config num.

Cheers,
Scott