From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] fix constness warning in dmapi
Date: Sat, 14 Jul 2007 11:45:04 -0500 [thread overview]
Message-ID: <4698FD90.10003@sandeen.net> (raw)
In-Reply-To: <20070714160910.GE7768@lst.de>
Christoph Hellwig wrote:
> File operations are const now so make sure the dmapi code propagates
> this properly.
ACK. Surprised that was still there :)
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/dmapi/dmapi_kern.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/dmapi/dmapi_kern.h 2007-07-14 16:08:31.000000000 +0200
> +++ linux-2.6-xfs/fs/dmapi/dmapi_kern.h 2007-07-14 16:08:41.000000000 +0200
> @@ -79,7 +79,7 @@ struct filesystem_dmapi_operations {
> int (*get_fsys_vector)(struct super_block *sb, void *addr);
> int (*fh_to_inode)(struct super_block *sb, struct inode **ip,
> dm_fid_t *fid);
> - struct file_operations * (*get_invis_ops)(struct inode *ip);
> + const struct file_operations * (*get_invis_ops)(struct inode *ip);
> int (*inode_to_fh)(struct inode *ip, dm_fid_t *fid,
> dm_fsid_t *fsid );
> void (*get_fsid)(struct super_block *sb, dm_fsid_t *fsid);
> Index: linux-2.6-xfs/fs/xfs/dmapi/xfs_dm_fsops.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/dmapi/xfs_dm_fsops.c 2007-07-14 16:07:47.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/dmapi/xfs_dm_fsops.c 2007-07-14 16:07:55.000000000 +0200
> @@ -49,7 +49,7 @@
> #include "xfs_dm.h"
>
>
> -STATIC struct file_operations *
> +STATIC const struct file_operations *
> xfs_dm_get_invis_ops(
> struct inode *ip)
> {
>
>
prev parent reply other threads:[~2007-07-14 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 16:09 [PATCH] fix constness warning in dmapi Christoph Hellwig
2007-07-14 16:45 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4698FD90.10003@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.