From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH IPTABLES 0/43]: Unification of ip[6]tables matches/targets #2 Date: Sun, 15 Jul 2007 16:41:10 +0200 Message-ID: <469A3206.7040805@trash.net> References: <200707141721.l6EHLOHo022296@toshiba.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org To: Yasuyuki KOZAKAI Return-path: In-Reply-To: <200707141721.l6EHLOHo022296@toshiba.co.jp> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Yasuyuki KOZAKAI wrote: > This patchset is for unifying codes in matches/targets of ip[6]tables. > The change from the last patchset is that all declarations in > iptables_common.h are moved into xtables.h > > I also attach patches to unify libip[6]t_NOTRACK and libip[6]t_multiport > respectively. The former is easiest case of unification, and later is > most complicated case. The patches for other matches/targets are also > attached, but I've not completed unification for all of matches/targets > yet. Your patches pretty good to me, apart from the minor issue noticed by Jan. I think we should put them in SVN now and convert over the remaining matches and targets as time permits.