From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] Change default KERNEL_DIR location and add KBUILD_OUTPUT Date: Sun, 15 Jul 2007 17:33:50 +0200 Message-ID: <469A3E5E.2010507@trash.net> References: <20070714201513.GA9970@titan.stealer.net> <469A3070.7030506@trash.net> <20070715153145.GA24365@titan.stealer.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: netfilter-devel@lists.netfilter.org To: Sven Wegener Return-path: In-Reply-To: <20070715153145.GA24365@titan.stealer.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Sven Wegener wrote: > On Sun, Jul 15, 2007 at 04:34:24PM +0200, Patrick McHardy wrote: > >>What do we need KBUILD_OUTPUT for? Just the source tree should be enough. > > > For current kernels, true. Older kernels (before 2006-04-26) and the > whole 2.6.16.y series have a bug where include/linux/netfilter_ipv4.h > includes linux/config.h which includes linux/autoconf.h which is placed > into KBUILD_OUTPUT. Just changing KERNEL_DIR from build to source should > be enough for recent kernels. For older kernels building the iptables > package will fail with "linux/autoconf.h: No such file or directory" > unless we add the KBUILD_OUTPUT bit. That's why I added it. Do we want > to have this workaround here? I don't see why not. A short comment in the Makefile explaining the situation would be nice though.