All of lore.kernel.org
 help / color / mirror / Atom feed
From: federico ferri <xaero@inwind.it>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dmitry.torokhov@gmail.com, linux-input@atrey.karlin.mff.cuni.cz,
	trivial@kernel.org
Subject: Re: [PATCH] input: change SysRq keycode for systems without SysRq key
Date: Sun, 15 Jul 2007 20:34:52 +0200	[thread overview]
Message-ID: <469A68CC.5040902@inwind.it> (raw)
In-Reply-To: <alpine.LFD.0.999.0707151102250.20061@woody.linux-foundation.org>

Linus Torvalds ha scritto:
> On Sun, 15 Jul 2007, federico ferri wrote:
>   
>> this patch adds an entry in Kconfig after 'config MAGIC_SYSRQ' which
>> asks for a different keycode (replacing also KEY_SYSRQ with
>> CONFIG_MAGIC_SYSRQ_KEYCODE in char/keyboard.c)
>>     
>
> Quite frankly, I think that if we want to make something like this 
> configurable, it should be dynamic, not compiled-in. So that the same 
> kernel image can be used with different keyboards.
>
> 		Linus
>
>   
That's right; but let me explain: I started this as a hack, just because
I both wanted to use this Apple USB keyboard and wanted to be able to
hit SysRq.

I have no experience at all in programming kernel. Even that small patch
it was reviewed and corrected by some people on kernel and input mailing
lists.

(I can imagine it could be done via a /proc/sysrq-keycode virtual file,
but that's just one possibility)

So, this should turn into a feature request...
would you accept feature requests?  ( :

-- 
Federico Ferri

  reply	other threads:[~2007-07-15 18:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-15 17:04 [PATCH] input: change SysRq keycode for systems without SysRq key federico ferri
2007-07-15 18:03 ` Linus Torvalds
2007-07-15 18:34   ` federico ferri [this message]
2007-07-15 18:57     ` Linus Torvalds
2007-07-15 22:04       ` federico ferri
2007-07-15 22:15         ` Linus Torvalds
2007-07-16 12:41           ` Dmitry Torokhov
2007-07-17  6:40             ` federico ferri
2007-07-17 15:11               ` Dmitry Torokhov
2007-07-18 20:55                 ` federico ferri
2007-07-19 21:00                   ` Dmitry Torokhov
2007-07-19 21:00                     ` Dmitry Torokhov
2007-07-19 21:39                     ` federico ferri
2007-07-19 22:32                       ` Dmitry Torokhov
2007-07-19 23:29                         ` federico ferri
2007-07-30 14:09                           ` Jiri Kosina
2007-08-02 21:27                             ` Vojtech Pavlik
2007-08-17  8:25                               ` Marvin Raaijmakers
2007-08-17 10:22                                 ` Jiri Kosina
2007-08-17 14:35                                   ` Marvin Raaijmakers
2007-08-17 14:42                                     ` Jiri Kosina
2007-08-17 15:01                                       ` Marvin Raaijmakers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469A68CC.5040902@inwind.it \
    --to=xaero@inwind.it \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=torvalds@linux-foundation.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.