Re: [PATCH 12/17] mount.nfs: Change *flags to flags

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Neil Brown wrote:
> On Sunday July 15, chuck.lever@oracle.com wrote:
>> It's not necessary to treat the *flags parameter to nfsmount and nfs4mount
>> as an output parameter.  Nothing is passed back.  Replace it with a normal
>> call-by-value.
> 
> And, in fact, very little is passed forward.
> nfs4mount doesn't use 'flags' at all... maybe it should?
> nfsmount uses it for one thing - checking in MS_REMOUNT was set.
> So maybe we should change the name to 'remount' and pass down
> 'flags & MS_REMOUNT' ??

The earlier patch to move the mount system call into nfsmount.c will 
need the
whole set of flags.  Likewise for nfs4mount.c.

Note this is also why MS_USER and MS_USERS need to be moved into 
mount_constants.h !  ;-)

> Most of the stuff the nfsmount doesn't do if MS_REMOUNT is talking to
> mountd which obviously is not relevant for NFSv4.  But NFSv4 still
> tries to ping the server... Should that be excluded in MS_REMOUNT is
> set, do you think?

I can take a look at that as a separate clean up.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 290 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs