From: Albert Lee <albertcc@tw.ibm.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
albertl@mail.com, jeff@garzik.org, alan@lxorguk.ukuu.org.uk,
dwm@enoyolf.org, linux-ide@vger.kernel.org, mlord@pobox.com
Subject: Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change
Date: Mon, 16 Jul 2007 17:19:34 +0800 [thread overview]
Message-ID: <469B3826.7040209@tw.ibm.com> (raw)
In-Reply-To: <469740D0.4000104@gmail.com>
Tejun Heo wrote:
> Tejun Heo wrote:
>
>>Mikael Pettersson wrote:
>>
>>>Albert's patch is OK as far as sata_promise is concerned, but
>>>I want to see an update of libata.tmpl and libata-eh.c to
>>>indicate the new, weakened, specification of freeze/thaw before
>>>I ACK this patch.
>
>
> Hmmm.... The docbook document is too stale at this point. It needs
> major rewrite. Also, I don't really think docbook is a good format for
> this type of documentation. Can we switch to formatted plain text which
> can be converted to other formats? Or use some form of inlined comment
> for callback documentation which can be gathered and formatted
> automatically?
>
> Albert, do you mind updating the comment in libata-eh.c?
>
No problem. Will fix the comments in the next revision.
--
albert
next prev parent reply other threads:[~2007-07-16 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 19:08 [PATCH 2/7] sata_promise: pdc_freeze() semantic change Mikael Pettersson
2007-07-10 16:06 ` Tejun Heo
2007-07-13 9:07 ` Tejun Heo
2007-07-16 9:19 ` Albert Lee [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-07 6:57 [PATCH 0/7] libata: irq_on/off restructuring (take #2) Albert Lee
2007-07-07 7:02 ` [PATCH 2/7] sata_promise: pdc_freeze() semantic change Albert Lee
2007-10-02 15:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469B3826.7040209@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertl@mail.com \
--cc=dwm@enoyolf.org \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.