From: Avi Kivity <avi@qumranet.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL][RESEND] KVM Updates for 2.6.23-rc1
Date: Mon, 16 Jul 2007 12:29:07 +0300 [thread overview]
Message-ID: <469B3A63.50206@qumranet.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0707151641560.20061@woody.linux-foundation.org>
Linus Torvalds wrote:
> On Sat, 14 Jul 2007, Avi Kivity wrote:
>
>> Linus, please do your usual thing from the repository and branch at
>>
>
> It has code like
>
> + /* Can deadlock when called with interrupts disabled */
> + WARN_ON(irqs_disabled());
> +
> /* prevent preemption and reschedule on another processor */
> int me = get_cpu();
>
> which is against the coding conventions (and shouldn't even compile
> cleanly - but maybe we don't have the "warn about C99 variable
> declarations" thng on?).
>
It's on. I guess I didn't notice because other changes triggered a
recompile of the whole tree.
> Please don't do that.
>
Fixed and rebased. I also silenced a few warnings on the UP case by
adding a missing #include. It's at the same place:
git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [GIT PULL][RESEND] KVM Updates for 2.6.23-rc1
Date: Mon, 16 Jul 2007 12:29:07 +0300 [thread overview]
Message-ID: <469B3A63.50206@qumranet.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0707151641560.20061-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Linus Torvalds wrote:
> On Sat, 14 Jul 2007, Avi Kivity wrote:
>
>> Linus, please do your usual thing from the repository and branch at
>>
>
> It has code like
>
> + /* Can deadlock when called with interrupts disabled */
> + WARN_ON(irqs_disabled());
> +
> /* prevent preemption and reschedule on another processor */
> int me = get_cpu();
>
> which is against the coding conventions (and shouldn't even compile
> cleanly - but maybe we don't have the "warn about C99 variable
> declarations" thng on?).
>
It's on. I guess I didn't notice because other changes triggered a
recompile of the whole tree.
> Please don't do that.
>
Fixed and rebased. I also silenced a few warnings on the UP case by
adding a missing #include. It's at the same place:
git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-16 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 6:01 [GIT PULL][RESEND] KVM Updates for 2.6.23-rc1 Avi Kivity
2007-07-14 6:01 ` Avi Kivity
2007-07-15 23:43 ` Linus Torvalds
2007-07-15 23:43 ` Linus Torvalds
2007-07-16 9:29 ` Avi Kivity [this message]
2007-07-16 9:29 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469B3A63.50206@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.