All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Ryan Power <rpower@sysreset.com>,
	jgarzik@pobox.com, Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.22.1] libata: Adjust libata to ignore errors after spinup
Date: Mon, 16 Jul 2007 19:07:36 -0400	[thread overview]
Message-ID: <469BFA38.1090309@rtr.ca> (raw)
In-Reply-To: <6.2.0.14.2.20070715210841.02fcab90@linux.sysreset.com>

Ryan Power wrote:
> From: Ryan Power <rpower@sysreset.com>
> 
> Adjust libata to ignore errors after spinup
> 
> This patch is to ignore errors from the spinup attempt if the drive is
> in the "standby id" state.

Jeff / Tejun:  here is Ryan's patch for his WD drive spinup problems.
This copy has the pathnames and whitespace repaired.
 
Signed-off-by: Ryan Power <rpower@sysreset.com>
Signed-off-by: Mark Lord <mlord@pobox.com>
---
Index: linux/drivers/ata/libata-core.c
--- old/drivers/ata/libata-core.c   2007-07-10 12:56:30.000000000 -0600
+++ linux/drivers/ata/libata-core.c       2007-07-15 01:58:49.000000000 -0600
@@ -1750,7 +1750,7 @@ int ata_dev_read_id(struct ata_device *d
		tf.protocol = ATA_PROT_NODATA;
		tf.flags |= ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE;
		err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0);
-		if (err_mask) {
+		if (err_mask && id[2] != 0x738c) {
			rc = -EIO;
			reason = "SPINUP failed";
			goto err_out;


  reply	other threads:[~2007-07-16 23:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13  6:14 Spinup command fails on WD3200JS Ryan Power
2007-07-13  9:21 ` Tejun Heo
2007-07-13 12:53 ` Mark Lord
2007-07-14  0:55   ` Ryan Power
2007-07-14  1:35     ` Mark Lord
2007-07-16  3:28       ` [PATCH 2.6.22.1] libata: Adjust libata to ignore errors after spinup Ryan Power
2007-07-16 23:07         ` Mark Lord [this message]
2007-07-16 23:15           ` Mark Lord
2007-07-16 23:19             ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469BFA38.1090309@rtr.ca \
    --to=liml@rtr.ca \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpower@sysreset.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.