All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Demski <fdemski@users.sourceforge.net>
To: alsa-devel@alsa-project.org
Subject: substream->private_data == NULL in hw_params
Date: Tue, 17 Jul 2007 03:00:44 +0200	[thread overview]
Message-ID: <469C14BC.1000606@users.sourceforge.net> (raw)

Hi there,

after many reboots I finally fixed an error in a driver but I am not 
sure if there ain't an underlying problem which causes this error.

The initialization is done with

        struct snd_pcm *pcm;
        int err;

        if((err = snd_pcm_new(chip->pod->line6.card, (char 
*)chip->pod->line6.devname, 0, 1, 1, &pcm)) < 0)
                return err;

        pcm->private_data = chip;
        pcm->private_free = pod_cleanup_pcm;
        chip->pcm = pcm;

However in hw_param, substream->private_data is NULL and I have to get 
the right value with this construct:

static int snd_pod_capture_hw_params(struct snd_pcm_substream 
*substream, struct snd_pcm_hw_params *hw_params)
{
        int ret;
        struct snd_pod_pcm *chip = snd_pcm_substream_chip(substream);

        /* -- Florian Demski [FD] */
        /* don't ask me why, but this fixes the bug on my machine */
        if ( chip == NULL ) {
                if ( substream->pcm == NULL )
                        return -ENOMEM;
                if ( substream->pcm->private_data == NULL )
                        return -ENOMEM;
                substream->private_data = substream->pcm->private_data;
                chip = snd_pcm_substream_chip( substream );
        }
        /* -- [FD] end */

Somehow only my machine produces this error, I tried switching off SMP 
and PREEMPT, but with no other result.

Or is this possibly an (undocumented) feature in alsa?

I'd be happy if actually some of you experienced guys might take a look 
at that driver:

SVN
https://line6linux.svn.sourceforge.net/svnroot/line6linux/driver/trunk

Browse
https://line6linux.svn.sourceforge.net/viewvc/line6linux/driver/trunk/

Thanks in advance,

Florian

             reply	other threads:[~2007-07-17  1:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-17  1:00 Florian Demski [this message]
2007-07-17 10:11 ` substream->private_data == NULL in hw_params Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469C14BC.1000606@users.sourceforge.net \
    --to=fdemski@users.sourceforge.net \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.