From: Jeff Garzik <jeff@garzik.org>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] drivers/base/core: improve device_add() error handling, fix bugs
Date: Wed, 18 Jul 2007 04:16:10 -0400 [thread overview]
Message-ID: <469DCC4A.9010001@garzik.org> (raw)
In-Reply-To: <20070718101501.6af017bc@gondolin.boeblingen.de.ibm.com>
Cornelia Huck wrote:
> On Wed, 18 Jul 2007 01:53:48 -0400,
> Jeff Garzik <jeff@garzik.org> wrote:
>
>> The following change was checked into 'warnings' branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
>>
>> commit 5330916f5a11d8b7def46a6b3e14a831684032f5
>> Author: Jeff Garzik <jeff@garzik.org>
>> Date: Wed Jul 18 01:41:29 2007 -0400
>>
>> drivers/base/core: improve device_add() error handling, fix bugs
>>
>> * silence several warnings by handling sysfs_create_link() failure
>>
>> * re-order some operations in error handling, to precisely reverse
>> the order of operations, i.e. unwind properly.
>>
>> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>>
>> drivers/base/core.c | 46 ++++++++++++++++++++++++++++++----------------
>> 1 file changed, 30 insertions(+), 16 deletions(-)
>
> Hm, what about driver-core-check-return-code-of-sysfs_create_link.patch
> (merged with ...-fix.patch) which has been in -mm for a while?
No idea, I didn't check there. If someone else has a better patch...
great! Let's merge it :)
Jeff
next prev parent reply other threads:[~2007-07-18 8:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 5:53 [PATCH 1/3] drivers/base/core: improve device_add() error handling, fix bugs Jeff Garzik
2007-07-18 5:55 ` [PATCH 2/3] drivers/video/aty/radeon_base: fix radeonfb_pci_register() err handling Jeff Garzik
2007-07-18 5:55 ` Jeff Garzik
2007-07-18 5:56 ` [PATCH 3/3] x86-64: make flush_tlb_kernel_range() a static inline function Jeff Garzik
2007-07-18 8:15 ` [PATCH 1/3] drivers/base/core: improve device_add() error handling, fix bugs Cornelia Huck
2007-07-18 8:16 ` Jeff Garzik [this message]
2007-07-18 8:36 ` Greg KH
2007-07-18 8:57 ` Cornelia Huck
2007-07-18 9:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469DCC4A.9010001@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=cornelia.huck@de.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.