All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@domain.hid>
To: xenomai-core <xenomai@xenomai.org>
Subject: [Xenomai-core] Problems with compat_module_param_array() with Linux 2.4
Date: Wed, 18 Jul 2007 15:08:37 +0200	[thread overview]
Message-ID: <469E10D5.8000602@domain.hid> (raw)

Hello,

yesterday I realized a problem with compat_module_param_array() with
ksrc/drivers/can/sja1000/rtcan_mem.c under Linux 2.4. It uses
CONFIG_XENO_DRIVERS_CAN_SJA1000_MEM_MAX_DEV to define the number of mem
devices, which is set to '(4)' by "make [menuc]onfig". Unfortunately, 
the brackets '()' break compat_module_param_array() because it treats 
the count as string:

#define compat_module_param_array(name, type, count, perm) \
         static inline void *__check_existence_##name(void) { return
&name; } \
         MODULE_PARM(name, "1-" __MODULE_STRING(count)
_MODULE_PARM_STRING_##type)

Any idea how to fix that? I actually tend to remove the configuration 
option CONFIG_XENO_DRIVERS_CAN_SJA1000_MEM_MAX_DEV and hardcode it to 
"4" (without brackets) in the driver. It's kind of overkill, anyhow.

Wolfgang.




             reply	other threads:[~2007-07-18 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18 13:08 Wolfgang Grandegger [this message]
2007-07-18 19:00 ` [Xenomai-core] Problems with compat_module_param_array() with Linux 2.4 Jan Kiszka
2007-08-15 16:15   ` Wolfgang Grandegger
2007-08-15 17:14     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469E10D5.8000602@domain.hid \
    --to=wg@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.