From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Subject: Re: 2.6.22-git* regression: Kconfig prompts without help text
Date: Wed, 18 Jul 2007 11:04:25 -0700 [thread overview]
Message-ID: <469E5629.4020409@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0707181954190.5385@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Jul 18 2007 10:34, Randy Dunlap wrote:
>>> On Jul 18 2007 09:41, Randy Dunlap wrote:
>>>> Looks good to me except that help text should be indented by
>>>> 2 more spaces according to CodingStyle.
>>> Who invented that rule anyway... the "---help---" marker (note the dashes)
>>> clearly separates things already.
>>> Here you go.
>> I have no idea where it came from. (not me)
>
> It was akpm:
> http://linux.bkbits.net:8080/linux-2.6/Documentation/CodingStyle?PAGE=diffs&REV=1.5
>
> Well, can we lift it?
I think that would only make sense if "---help---" is used (like you did)
instead of the plain "help" string.
In the case of "---help---", it's OK with me not to be indented by 2 more
spaces.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-07-18 18:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 18:49 2.6.22-git* regression: Kconfig prompts without help text Stefan Richter
2007-07-18 15:18 ` Jan Engelhardt
2007-07-18 16:00 ` Stefan Richter
2007-07-18 16:41 ` Randy Dunlap
2007-07-18 17:17 ` Jan Engelhardt
2007-07-18 17:34 ` Randy Dunlap
2007-07-18 17:55 ` Jan Engelhardt
2007-07-18 18:04 ` Randy Dunlap [this message]
2007-07-18 18:33 ` Jan Engelhardt
2007-07-18 18:37 ` Adrian Bunk
2007-07-19 20:26 ` Geert Uytterhoeven
2007-07-19 20:26 ` Geert Uytterhoeven
2007-07-19 20:49 ` Stefan Richter
2007-07-19 20:49 ` Stefan Richter
2007-07-19 21:05 ` Geert Uytterhoeven
2007-07-19 21:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469E5629.4020409@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.