From: Jan Kiszka <jan.kiszka@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: [Xenomai-core] [PATCH] fix regression around one-shot host tick
Date: Thu, 19 Jul 2007 09:22:32 +0200 [thread overview]
Message-ID: <469F1138.3050705@domain.hid> (raw)
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
Philippe,
this bug was introduced with recent clock_event modifications:
--- ksrc/nucleus/timer.c (Revision 2766)
+++ ksrc/nucleus/timer.c (Arbeitskopie)
@@ -245,7 +245,7 @@ void xntimer_tick_aperiodic(void)
translates into precious microsecs on low-end hw. */
__setbits(sched->status, XNHTICK);
if (!testbits(timer->status, XNTIMER_PERIODIC))
- goto out;
+ continue;
}
do {
@@ -254,7 +254,6 @@ void xntimer_tick_aperiodic(void)
xntimer_enqueue_aperiodic(timer);
}
-out:
__clrbits(sched->status, XNINTCK);
xntimer_next_local_shot(sched);
It doesn't look like typo, so what was your original intention? The current code at least fails to handle outstanding timers that are enqueued right behind a one-shot host-tick timer.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]
next reply other threads:[~2007-07-19 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 7:22 Jan Kiszka [this message]
2007-07-19 9:05 ` [Xenomai-core] [PATCH] fix regression around one-shot host tick Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469F1138.3050705@domain.hid \
--to=jan.kiszka@domain.hid \
--cc=rpm@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.