From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Roland Dreier <rdreier@cisco.com>, Andi Kleen <ak@suse.de>,
Christoph Lameter <clameter@sgi.com>,
linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@dev.mellanox.co.il>
Subject: Re: kmalloc zero size changes break i386
Date: Thu, 19 Jul 2007 22:03:31 +0300 [thread overview]
Message-ID: <469FB583.7070502@cs.helsinki.fi> (raw)
In-Reply-To: <alpine.LFD.0.999.0707191107570.27353@woody.linux-foundation.org>
Linus Torvalds wrote:
> Ok, I think I see it: I think the mm/slab.c conversion of kmalloc(0) is
> totally broken.
>
> The problem? It returns ZERO_SIZE_PTR from __find_general_cachep(), not
> from __kmalloc(). So anythign that uses __find_general_cachep() will get
> an invalid cachep pointer, which was not the point.
>
> Does something like this fix it?
I wondered about that too but I didn't spot any callers that would
actually break. Andi? Roland?
> Christoph, please go over this and see if there are other cases like that.
__do_kmalloc_node probably.
Pekka
next prev parent reply other threads:[~2007-07-19 19:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 10:01 kmalloc zero size changes break i386 Andi Kleen
2007-07-19 14:08 ` Pekka Enberg
2007-07-19 15:17 ` Roland Dreier
2007-07-19 18:11 ` Linus Torvalds
2007-07-19 19:03 ` Pekka Enberg [this message]
2007-07-19 19:19 ` Linus Torvalds
2007-07-19 21:03 ` Andi Kleen
2007-07-20 7:12 ` Pekka J Enberg
2007-07-20 7:18 ` Pekka J Enberg
2007-07-20 19:13 ` [PATCH] Fix ZERO_OR_NULL_PTR(ZERO_SIZE_PTR) Roland Dreier
2007-07-19 17:01 ` kmalloc zero size changes break i386 Andi Kleen
2007-07-19 15:57 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469FB583.7070502@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=ak@suse.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@dev.mellanox.co.il \
--cc=rdreier@cisco.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.