From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <469FC275.7050309@smiths-aerospace.com> Date: Thu, 19 Jul 2007 15:58:45 -0400 From: Jerry Van Baren MIME-Version: 1.0 To: Grant Likely Subject: Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path References: <20070719183415.7458.42622.stgit@trillian> <20070719183734.7458.83695.stgit@trillian> <469FB47D.4030009@freescale.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Grant Likely wrote: > On 7/19/07, Scott Wood wrote: >> Grant Likely wrote: >>> From: Grant Likely >>> >>> To boot from a cuImage requires the device tree to have a >>> linux,stdout-path property in the chosen node. This patch adds it >>> to the .dts files. >> This will break many current u-boots, as they blindly add a /chosen node >> regardless of whether one already exists. > > That really should be fixed then. In the meantime; I'll resubmit the > patch to add the chosen node; but with it commented out. > > g. We are working on fixing that with the "u-boot-fdt" subtree, but it is slow going and it will not magically fix already fielded boards. (Forget that Harry Potter crap magic, _that_ would be some useful magic!) I think the "proper" solution is not to add the /chosen node in the dts but rather to generate a _correct_ one in u-boot. Note that linux,stdout-path is something that _should_ be generated based on the u-boot configuration (currently it is hard #defined, IMHO it should be part of the u-boot environment). Looks like it is at fdt_support.c line 152: Best regards, gvb