From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: PATCH: Enable QEMU booting of blktap disks Date: Fri, 20 Jul 2007 15:33:07 +0200 Message-ID: <46A0B993.7000801@redhat.com> References: <20070719170922.GE26669@redhat.com> <46A08FEE.70908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andrew Warfield Cc: xen-devel@lists.xensource.com, "Daniel P. Berrange" List-Id: xen-devel@lists.xenproject.org Andrew Warfield wrote: > Gerd, don't misunderstand what I'm saying: I'd be delighted to see > blktap and qemu share block device implementations. However, the > blktap patch that I am commenting on achieves exactly the opposite of > that: it *requires* two implementations of any virtual disk type that > you want to use PV drivers on in an HVM guest. Well, the code will be in qemu anyway because other people use it, no matter whenever the xenified qemu device model actually uses it or not (with the phantom device redirection trick). So if you want to get rid of code duplication either shared libs or redirecting things the other way around (i.e. use qemu code for both hvm and pv) will work. cheers, Gerd