From: "H. Peter Anvin" <hpa@zytor.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Andi Kleen <ak@novell.com>,
Arthur Jones <arthur.jones@qlogic.com>,
Vasily Tarasov <vtaras@openvz.org>,
linux-kernel@vger.kernel.org, Jan Kara <jack@ucw.cz>,
linux-arch@vger.kernel.org
Subject: Re: build fix for x86_64...
Date: Fri, 20 Jul 2007 10:03:04 -0700 [thread overview]
Message-ID: <46A0EAC8.9020203@zytor.com> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A01FA46A9@scsmsx411.amr.corp.intel.com>
Luck, Tony wrote:
>
> Which is better. But if we unconditionally set this CONFIG variable, then the
> code in fs/quota.c will have to read:
>
> #if defined(CONFIG_COMPAT) && defined(CONFIG_COMPAT_FOR_U64_ALIGNMENT)
>
> We can keep it simpler if the Kconfig file does the conditional for us:
>
> config COMPAT_FOR_U64_ALIGNMENT
> def_bool y
> depends on COMPAT
>
No, that would be bad. If compat_u64 is used to carry 32-bit ABIs
forward into 64-bit space without needing compatibility hacks, then this
would actually introduce ABI incompatibilities depending on CONFIG_COMPAT!
-hpa
next prev parent reply other threads:[~2007-07-20 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 22:24 build fix for x86_64 Arthur Jones
2007-07-19 23:09 ` Andi Kleen
2007-07-19 23:54 ` Luck, Tony
2007-07-19 23:54 ` Luck, Tony
2007-07-20 8:32 ` Andi Kleen
2007-07-20 15:55 ` Randy Dunlap
2007-07-20 16:20 ` Luck, Tony
2007-07-20 16:20 ` Luck, Tony
2007-07-20 16:48 ` Matthew Wilcox
2007-07-20 17:03 ` H. Peter Anvin [this message]
2007-07-20 17:25 ` Andi Kleen
2007-07-20 17:38 ` H. Peter Anvin
2007-07-20 17:40 ` Andreas Schwab
2007-07-20 17:45 ` H. Peter Anvin
2007-07-20 18:13 ` Andi Kleen
2007-07-20 19:29 ` H. Peter Anvin
2007-07-20 22:08 ` Luck, Tony
2007-07-20 22:08 ` Luck, Tony
2007-07-20 22:34 ` H. Peter Anvin
2007-07-20 18:27 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A0EAC8.9020203@zytor.com \
--to=hpa@zytor.com \
--cc=ak@novell.com \
--cc=arthur.jones@qlogic.com \
--cc=jack@ucw.cz \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=tony.luck@intel.com \
--cc=vtaras@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.