From mboxrd@z Thu Jan  1 00:00:00 1970
From: Henning Sprang <henning_sprang@gmx.de>
Subject: Re: Xendomain Bug
Date: Sun, 22 Jul 2007 13:33:13 +0200
Message-ID: <46A34079.3010507@gmx.de>
References: <C2B7B21B.12107%keir@xensource.com> <46922744.60403@gmx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <46922744.60403@gmx.de>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Henning Sprang <henning_sprang@gmx.de>
Cc: Xen <xen-devel@lists.xensource.com>, Keir Fraser <keir@xensource.com>
List-Id: xen-devel@lists.xenproject.org

Henning Sprang wrote:
> Keir Fraser wrote:
>> Changeset 15384 in xen-unstable (committed on June 19th) should fix this
>> issue.

Hmm, there is still one question left:

The fix I proposed is a patch of about two lines - as can be seen here:
http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=859

The fix you took in was much larger instead - in fact 2 lines vs. 20.

see: http://xenbits.xensource.com/xen-unstable.hg?rev/865c4ae59be3

Is there something totally wrong with the small patch that I oversaw?

Not that I have the urgent need to get my own patches in, but I usually
tend to think smaller patches should be better, and having less code to
maintain is better - and if I propose bad things, I want to know about it :)

Henning