All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCh 4/4] Speed up sensors_get_ignored()
Date: Sun, 22 Jul 2007 15:09:28 +0000	[thread overview]
Message-ID: <46A37328.5000106@hhs.nl> (raw)
In-Reply-To: <20070722165337.20c91514@hyperion.delvare>

Jean Delvare wrote:
> Now that sensors_get_ignored() is an internal function, we can change
> its prototype to suit our needs better.
> 
> * Pass the chip name by address.
> * Pass the feature directly rather than its number.
> * Switch to a sane convention for the returned value.
> * Don't check for errors that can't happen.
> 
> ---
>  lib/access.c |   41 ++++++++++++++++++-----------------------
>  1 file changed, 18 insertions(+), 23 deletions(-)
> 

And once more the patch looks good.

Regards,

Hans


p.s.

Let me know when this all lands, then I'll run another round of tests.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2007-07-22 15:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-22 14:53 [lm-sensors] [PATCh 4/4] Speed up sensors_get_ignored() Jean Delvare
2007-07-22 15:09 ` Hans de Goede [this message]
2007-07-22 20:58 ` Jean Delvare
2007-07-24  9:34 ` Jean Delvare
2007-07-25  7:31 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A37328.5000106@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.