From: Gabriel C <nix.or.die@googlemail.com>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: Richard Purdie <rpurdie@rpsys.net>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [FIX] struct led_classdev conversion compile fallout
Date: Mon, 23 Jul 2007 14:15:10 +0200 [thread overview]
Message-ID: <46A49BCE.6020406@googlemail.com> (raw)
In-Reply-To: <200707231403.06015.agruen@suse.de>
Andreas Gruenbacher wrote:
> Commit f8a7c6fe switched from a struct class_device to a struct device in
> struct led_classdev. Need to adjust drivers/misc/asus-laptop.c as well.
>
> Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
>
> diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
> index f753060..2fdee5b 100644
> --- a/drivers/misc/asus-laptop.c
> +++ b/drivers/misc/asus-laptop.c
> @@ -1067,8 +1067,8 @@ static void asus_backlight_exit(void)
> }
>
> #define ASUS_LED_UNREGISTER(object) \
> - if(object##_led.class_dev \
> - && !IS_ERR(object##_led.class_dev)) \
> + if(object##_led.dev \
> + && !IS_ERR(object##_led.dev)) \
> led_classdev_unregister(&object##_led)
>
> static void asus_led_exit(void)
Same fix here -> http://lkml.org/lkml/2007/7/23/137 but see Al Viro comment about -> http://lkml.org/lkml/2007/7/23/139
Regards,
Gabriel C
prev parent reply other threads:[~2007-07-23 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 12:03 [FIX] struct led_classdev conversion compile fallout Andreas Gruenbacher
2007-07-23 12:15 ` Gabriel C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A49BCE.6020406@googlemail.com \
--to=nix.or.die@googlemail.com \
--cc=agruen@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.