Re: Patch to support LUKS UUIDs in libblkid

[Karsten Hopp <karsten@redhat.com>]

Theodore Tso schrieb:
> Thanks, I've applied the blkid LUKS patch to the e2fsprogs SCM (modulo
> a minor whitespace breakage which I fixed up).
>

  I've encountered a problem with this patch, consider the following
  setup:

  in /etc/fstab:
  UUID=<some LUKS uuid>  / ext3 defaults 0 0

  During bootup the init scripts run 'fsck -A', fsck reads in /etc/fstab and
  converts the LUKS-uuid to a device name. It then uses this devicename to
  populate filesys_info and sets the type to ext3 (from fstab). It then tries to check
  the underlying device instead of the /dev/mapper/ LUKS device.

  I'm not sure how to work around this, adding crypt_luks to ignored_types won't work
  because fsck thinks the device has an ext3 FS.
  Is create_fs_device() the right place to add a check if this is a LUKS device or would it be better
  to do that in parse_fstab_line() around the blkid_get_devname() call ?

  Karsten


--
  Karsten Hopp        | Mail: karsten@redhat.de
  Red Hat Deutschland | Tel: +49-711-96437-0
  Hauptstaetterstr.58 | Fax: +49-711-613590
  D-70178 Stuttgart   | http://www.redhat.de