Re: [PATCH] S3C24XX large page NAND support

[Matthieu CASTET <matthieu.castet@parrot.com>]

Hi Ben,

Ben Dooks wrote:
> On Thu, Jul 12, 2007 at 12:04:03PM +0200, Matthieu CASTET wrote:
> [snip]
>>>  
>>> -		nmtd->scan_res = nand_scan(&nmtd->mtd, (sets) ? sets->nr_chips : 1);
>>> +		nmtd->scan_res = nand_scan_ident(&nmtd->mtd,
>>> +						 (sets) ? sets->nr_chips : 1);
>>>  
>>>  		if (nmtd->scan_res == 0) {
>>> +			s3c2410_nand_update_chip(info, nmtd);
>>> +			nand_scan_tail(&nmtd->mtd);
>>>  			s3c2410_nand_add_partition(info, nmtd, sets);
>>>  		}
>> Shouldn't nand_scan_ident and nand_scan_tail be used here ?
> 
> Sorry, do you mean that they should be used here (and they are
> being used in this code) or do you mean that you do not think
> that these two are to be used here?
> 
Sorry for the noise, I misread the patch and was thinking nand_scan was 
still used.

Again sorry.


Matthieu