From: Chuck Lever <chuck.lever@oracle.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix broken handling of port=... in NFS option parsing
Date: Mon, 23 Jul 2007 12:05:50 -0400 [thread overview]
Message-ID: <46A4D1DE.6070702@oracle.com> (raw)
In-Reply-To: <20070722095906.GX21668@ftp.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
ACK.
Al Viro wrote:
> Obviously broken on little-endian; fortunately, the option is
> not frequently used...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index b34b7a7..b2a851c 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -732,7 +732,7 @@ static int nfs_parse_mount_options(char *raw,
> return 0;
> if (option < 0 || option > 65535)
> return 0;
> - mnt->nfs_server.address.sin_port = htonl(option);
> + mnt->nfs_server.address.sin_port = htons(option);
> break;
> case Opt_rsize:
> if (match_int(args, &mnt->rsize))
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 259 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard
prev parent reply other threads:[~2007-07-23 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 9:59 [PATCH] fix broken handling of port=... in NFS option parsing Al Viro
2007-07-22 15:52 ` Trond Myklebust
2007-07-23 16:05 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A4D1DE.6070702@oracle.com \
--to=chuck.lever@oracle.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.