All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Vinson <rvinson@mvista.com>
To: Zang Roy-r61911 <tie-fei.zang@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 5/6 v2] 85xxCDS: Misc 8548 PCI Corrections.
Date: Mon, 23 Jul 2007 11:04:14 -0700	[thread overview]
Message-ID: <46A4ED9E.6010307@mvista.com> (raw)
In-Reply-To: <1185185072.25737.1.camel@localhost.localdomain>

Zang Roy-r61911 wrote:
> On Sat, 2007-07-21 at 06:31, Randy Vinson wrote:
> 
>> @@ -272,10 +272,10 @@ static void __init mpc85xx_cds_setup_arch(void)
>>         for (np = NULL; (np = of_find_node_by_type(np, "pci")) !=
>> NULL;) {
>>                 struct resource rsrc;
>>                 of_address_to_resource(np, 0, &rsrc);
>> -               if ((rsrc.start & 0xfffff) == 0x9000)
>> -                       fsl_add_bridge(np, 0);
>> -               else
>> +               if ((rsrc.start & 0xfffff) == 0x8000)
>>                         fsl_add_bridge(np, 1);
>> +               else
>> +                       fsl_add_bridge(np, 0);
> Why this is needed?
> For pcie@a000, fsl_add_bridge(np, 0)?
The old version of the code would call fsl_add_bridge(np, 1) for the
host bridges @8000 and @a000. When I tried it that way, it didn't work.
I don't think you can have 2 primary bridges.

Randy V.

  reply	other threads:[~2007-07-23 18:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-20 18:56 [PATCH 5/6] 85xxCDS: Misc 8548 PCI Corrections Randy Vinson
2007-07-20 21:11 ` Kumar Gala
2007-07-20 22:14   ` Randy Vinson
2007-07-20 22:31     ` [PATCH 5/6 v2] " Randy Vinson
2007-07-23 10:04       ` Zang Roy-r61911
2007-07-23 18:04         ` Randy Vinson [this message]
2007-07-24  5:35           ` Zang Roy-r61911
2007-07-24  7:07             ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A4ED9E.6010307@mvista.com \
    --to=rvinson@mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tie-fei.zang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.