From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Whitcroft Subject: Re: [patch 1/3] ps3: Disk Storage Driver Date: Tue, 24 Jul 2007 12:44:16 +0100 Message-ID: <46A5E610.7000508@shadowen.org> References: <20070716161539.075822000@pademelon.sonytel.be> <20070716162206.392129000@pademelon.sonytel.be> <20070718163637.3f0e0164.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hellhawk.shadowen.org ([80.68.90.175]:3799 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752058AbXGXLof (ORCPT ); Tue, 24 Jul 2007 07:44:35 -0400 In-Reply-To: <20070718163637.3f0e0164.akpm@linux-foundation.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Andrew Morton Cc: Geert Uytterhoeven , Paul Mackerras , Jens Axboe , "James E.J. Bottomley" , Alessandro Rubini , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Geoff Levand , Jens Axboe Andrew Morton wrote: >> + start_sector = req->sector*priv->blocking_factor; >> + sectors = req->nr_sectors*priv->blocking_factor; > > s/*/ * /. checkpatch missed this. Ok, this is something we need to decide on. Currently we only ask for consistent spacing on all the mathematic operators. This is mostly as we do see a large number of non-spaced uses in defines and the like. I am happy to expand these tests so they are always spaced on both sides style if that is the preference. -apw From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hellhawk.shadowen.org (hellhawk.shadowen.org [80.68.90.175]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 480F4DDE35 for ; Tue, 24 Jul 2007 22:11:42 +1000 (EST) Message-ID: <46A5E610.7000508@shadowen.org> Date: Tue, 24 Jul 2007 12:44:16 +0100 From: Andy Whitcroft MIME-Version: 1.0 To: Andrew Morton Subject: Re: [patch 1/3] ps3: Disk Storage Driver References: <20070716161539.075822000@pademelon.sonytel.be> <20070716162206.392129000@pademelon.sonytel.be> <20070718163637.3f0e0164.akpm@linux-foundation.org> In-Reply-To: <20070718163637.3f0e0164.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Cc: Jens Axboe , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Alessandro Rubini , linuxppc-dev@ozlabs.org, Paul Mackerras , Jens Axboe , Geert Uytterhoeven List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Andrew Morton wrote: >> + start_sector = req->sector*priv->blocking_factor; >> + sectors = req->nr_sectors*priv->blocking_factor; > > s/*/ * /. checkpatch missed this. Ok, this is something we need to decide on. Currently we only ask for consistent spacing on all the mathematic operators. This is mostly as we do see a large number of non-spaced uses in defines and the like. I am happy to expand these tests so they are always spaced on both sides style if that is the preference. -apw