From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Storm-Olsen Subject: Re: [PATCH 3/3] Teach "git branch" about --new-workdir Date: Tue, 24 Jul 2007 14:28:22 +0200 Message-ID: <46A5F066.9040201@trolltech.com> References: <20070723035644.GC32566@spearce.org> <7v1wezohi4.fsf@assigned-by-dhcp.cox.net> <46A5B5F5.6000202@trolltech.com> <7vd4yigmla.fsf@assigned-by-dhcp.cox.net> <46A5DF1F.2030307@trolltech.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigCC5A0CD220C5DA800C602A6B" Cc: Junio C Hamano , Johannes Schindelin , "Shawn O. Pearce" , git@vger.kernel.org To: Julian Phillips X-From: git-owner@vger.kernel.org Tue Jul 24 14:27:53 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IDJUW-0006kg-FA for gcvg-git@gmane.org; Tue, 24 Jul 2007 14:27:52 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753996AbXGXM1t (ORCPT ); Tue, 24 Jul 2007 08:27:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752903AbXGXM1t (ORCPT ); Tue, 24 Jul 2007 08:27:49 -0400 Received: from esparsett.troll.no ([62.70.27.18]:41393 "EHLO esparsett.troll.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879AbXGXM1s (ORCPT ); Tue, 24 Jul 2007 08:27:48 -0400 Received: from esparsett.troll.no (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id 3CE3574195; Tue, 24 Jul 2007 14:27:47 +0200 (CEST) Received: from [10.3.4.215] (error.troll.no [10.3.4.215]) by esparsett.troll.no (Postfix) with ESMTP id 24D517418D; Tue, 24 Jul 2007 14:27:47 +0200 (CEST) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070716 Thunderbird/2.0.0.5 Mnenhy/0.7.5.666 In-Reply-To: X-Enigmail-Version: 0.95.2 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEXU1NTAwMABAQGsrKyE hIQwMDAEBAS8hGUfAAACQUlEQVQ4jV2TS47cMAxEKSDZW1CfwMB4PYLkrKchsveJRR2gEen+R0hR 9vziBmahhyqSRQ4NfF1FmIv3dH4usNAGoFprBVguQJmZ1nX0XiHgEukTCK3TairiZeXcVGzmZIoU 3738pehdVbiU9KFgMQWeZ1fpHZDfRS4rPb3eQVaZChGx4ikt5GDkAZQ2KKohzjklno4+iJpVhxka ZjSpasJ4gdGaEQMWTMjRa5uTqza0XDJjzhIdzGTMrqoopimoIPCKZtVOq265MAXpMLXycmVl2Y8C oE1FkT/faKauOjYoHJyOxHfvixjowvI0xZJsKykubgLYzuJMdBO+L86TjxfQ9hz9jpSudbnXXzRm tor5i3MUONpOfARAhlWbzWF7OhP2eSeEW9HUBNiHOxUM8HLWHhUAj3NZNsdqRZpNA+DJ+XlX+Qc9 Z4ZjHX8LRUzgTBBef84NQoCMOcS0+BMsj3klbTzRri03ugXr9em1GfgzDAyEn4J3fvFI5YwdTrYu 1ntAY1h5ysM2OMGm+cBOocCXHisAHu2PagnLghoG2krz8bzsA4fj7KxCGk+63jt+DDCtYjbFNkHD nRwpRqsQYx5WYzsbm/eBfn0I4TbOGvMWqhQAiEDzNs4apumCI0x2OyHtY7uAlZff/sanbH9+AGT1 KOEmUlJISdYPgEgehw+cTZEf6xeFyoEjCPgv+A62KhW3EOy9PL7WmCBMRWmfYN0OqW9krzl/Ay91 75HMqfDtP8UFckFUX2rwrm/kTVB2gH+hdu4avZVCuAAAAABJRU5ErkJggg== Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCC5A0CD220C5DA800C602A6B Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable >> The new-workdir feature doesn't *have* to be about symlinked >> .git/ metainfo space, but could also be about symref'ed .git/ >> metainfo. (A discussion was done in 2005s "Getting rid of >> symlinks in .git?", but the conclusion was that it would slow it >> down too much? *ponder*) >=20 > Symref'ed isn't really the right term ... we're not talking about > refs here. You would have to basically implement symlinks _inside_ > git ... Yes, sorry for mixing up the terms here. > New-workdir really _is_ all about symlinks. It already exists as a > contrib feature - and moving it into core is (as I understand it) > really just moving it, not redesigning. Yes, if simply moving into is core is good enough. IMHO since its=20 based largely on FS symlinks it needs a slight redesign before it can=20 be moved into core to make it platform agnostic. If not, it should=20 remain contrib [again, IMHO]. > If you were going to avoid symlinks, then probably the cleanest way > would be to have an explict way to point at the actual repo - > rather than making the working look like a repo if you squint hard > enough. Which sounds rather like it would be an extension to > GIT_DIR + GIT_WORK_TREE. I haven't looked at it, but it shouldn't > be too hard to have a mechanism that automatically does > GIT_DIR=3D GIT_WORK_TREE=3D=3D when the appropriate setup = is > in place? Though you would have to get it into all the appropriate > places ... *nod* --=20 =2Emarius --------------enigCC5A0CD220C5DA800C602A6B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (MingW32) iD8DBQFGpfBnKzzXl/njVP8RAgS1AKDXVFXKlsENgDM4RO25ls9a0pqwVACfZjkY kAAuGLsswyDNxnf9TbycZRU= =Zn4L -----END PGP SIGNATURE----- --------------enigCC5A0CD220C5DA800C602A6B--