All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: new device-mapper required to build latest lvm from cvs
Date: Wed, 25 Jul 2007 17:04:14 -0400	[thread overview]
Message-ID: <46A7BACE.1020100@ce.jp.nec.com> (raw)
In-Reply-To: <20070725203255.GC459@agk.fab.redhat.com>

Alasdair G Kergon wrote:
> On Wed, Jul 25, 2007 at 09:10:05PM +0100, Alasdair G Kergon wrote:
>> Don't bother: if the functions are identical today, remove the lvm2
>> wrapper and have everything call the dm version directly.
> 
> The functions are not quite identical:-)
>   1 - a log_sys_error() cleanup missing

I thought they are identical after the macro is expanded.
Should I use log_sys_error() in libdevmapper, too?

>   2 - error suppression for read-only filesystems

It can be brought into dm_create_dir() or we can move logging
to the outside of dm_create_dir() and let callers do it.
Which way do you think is better?

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America



  reply	other threads:[~2007-07-25 21:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24 17:51 new device-mapper required to build latest lvm from cvs Jim Meyering
2007-07-25 19:57 ` [lvm-devel] " Jun'ichi Nomura
2007-07-25 19:57   ` Jun'ichi Nomura
2007-07-25 20:01   ` [lvm-devel] " Jun'ichi Nomura
2007-07-25 20:01     ` Jun'ichi Nomura
2007-07-25 20:10     ` Alasdair G Kergon
2007-07-25 20:32       ` Alasdair G Kergon
2007-07-25 21:04         ` Jun'ichi Nomura [this message]
2007-07-26 18:38           ` Jun'ichi Nomura
2007-07-26 20:34             ` Jun'ichi Nomura
2007-07-26 18:39           ` Jun'ichi Nomura
2007-07-25 20:43       ` Jun'ichi Nomura
2007-07-28 13:06   ` [lvm-devel] " Jim Meyering
2007-07-28 13:06     ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A7BACE.1020100@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.