All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: Tc filtering: broken 802_3 classifier?
Date: Thu, 26 Jul 2007 01:11:14 +0200	[thread overview]
Message-ID: <46A7D892.3020505@trash.net> (raw)
In-Reply-To: <D5C1322C3E673F459512FB59E0DDC329034BF7F6@orsmsx414.amr.corp.intel.com>

Waskiewicz Jr, Peter P wrote:
>>Waskiewicz Jr, Peter P wrote:
>>
>>I'm not sure what you're expecting. skb->protocol is usually not set
>>to ETH_P_802_3, which is why the filter is not matching.
> 
> 
> I understand that.  I had two issues, which you cleared up one by
> reminding me that the protocol matches on skb->protocol before it tries
> to run the ->classify() routine.  The other issue I am seeing is with 8
> bands, an 802_3 filter is affecting classification of IP traffic.  For
> example, I have an 802_3 filter to look for dst MAC address, but an ssh
> packet, which without any filters should go into flowid 1:3 on my
> system, is getting pushed into flowid 1:1.  I remove the 802_3 filter,
> and ssh traffic starts going back into 1:3.  No other filters on the
> system.  That's the main issue I'm seeing, so I'll keep investigating to
> see what's going on.


In case of prio, if your manually installed filters don't match, it will
fall back to the skb->priority based classification, which is based
on tos and is probably responsible for what you're seeing. Feel free to
investigate, but you could save us all some time by simply posting what
you're doing, what you're expecting and what is actually happening,
there's probably a good explanation.


  reply	other threads:[~2007-07-25 23:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-25  0:19 Tc filtering: broken 802_3 classifier? Waskiewicz Jr, Peter P
2007-07-25  0:31 ` Patrick McHardy
2007-07-25 17:24   ` Waskiewicz Jr, Peter P
2007-07-25 17:28     ` Patrick McHardy
2007-07-25 17:34       ` Waskiewicz Jr, Peter P
2007-07-25 23:11         ` Patrick McHardy [this message]
2007-07-25 23:34           ` Waskiewicz Jr, Peter P
2007-07-25 23:40             ` Patrick McHardy
2007-07-25 23:58               ` Patrick McHardy
2007-07-26  0:10                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A7D892.3020505@trash.net \
    --to=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.