All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Williams <pwil3058@bigpond.net.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: Gregory Haskins <ghaskins@novell.com>,
	jim.houston@ccur.com, joe.korty@ccur.com, rostedt@goodmis.org,
	tglx@linutronix.de, dwalker@mvista.com,
	David Bahi <DBahi@novell.com>, Moiz Kohari <MKohari@novell.com>,
	Sven Dietrich <SDietrich@novell.com>,
	dsaxena@plexity.net, williams@redhat.com, abogani@texware.it,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Minor errors in 2.6.23-rc1-rt2 series
Date: Thu, 26 Jul 2007 11:24:14 +1000	[thread overview]
Message-ID: <46A7F7BE.1030100@bigpond.net.au> (raw)
In-Reply-To: <20070712130958.GB17494@elte.hu>

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

I've just been reviewing these patches and have spotted a couple of
errors that look like they were caused by fuzz during the patch process.

A patch that corrects the errors is attached.

Cheers
Peter
-- 
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
 -- Ambrose Bierce


[-- Attachment #2: fix-fuzz-related-errors --]
[-- Type: text/plain, Size: 1484 bytes --]

diff -r e02fd64426b9 arch/i386/boot/compressed/Makefile
--- a/arch/i386/boot/compressed/Makefile	Thu Jul 26 10:33:58 2007 +1000
+++ b/arch/i386/boot/compressed/Makefile	Thu Jul 26 11:17:35 2007 +1000
@@ -9,10 +9,9 @@ EXTRA_AFLAGS	:= -traditional
 EXTRA_AFLAGS	:= -traditional
 
 LDFLAGS_vmlinux := -T
-CFLAGS := -m32 -D__KERNEL__ -Iinclude -O2  -fno-strict-aliasing
 hostprogs-y	:= relocs
 
-CFLAGS  := -m32 -D__KERNEL__ $(LINUX_INCLUDE) -O2 \
+CFLAGS  := -m32 -D__KERNEL__ $(LINUX_INCLUDE) -Iinclude -O2 \
 	   -fno-strict-aliasing -fPIC \
 	   $(call cc-option,-ffreestanding) \
 	   $(call cc-option,-fno-stack-protector)
diff -r e02fd64426b9 arch/i386/kernel/smp.c
--- a/arch/i386/kernel/smp.c	Thu Jul 26 10:33:58 2007 +1000
+++ b/arch/i386/kernel/smp.c	Thu Jul 26 11:17:35 2007 +1000
@@ -651,7 +651,6 @@ fastcall notrace void smp_reschedule_int
 fastcall notrace void smp_reschedule_interrupt(struct pt_regs *regs)
 {
 	trace_special(regs->eip, 0, 0);
-	trace_special(regs->eip, 0, 0);
 	ack_APIC_irq();
 	set_tsk_need_resched(current);
 }
diff -r e02fd64426b9 include/asm-mips/mipsregs.h
--- a/include/asm-mips/mipsregs.h	Thu Jul 26 10:33:58 2007 +1000
+++ b/include/asm-mips/mipsregs.h	Thu Jul 26 11:17:35 2007 +1000
@@ -710,7 +710,7 @@ do {									\
 	unsigned long long __val;					\
 	unsigned long __flags;						\
 									\
-	local_irq_save(flags);					\
+	local_irq_save(__flags);					\
 	if (sel == 0)							\
 		__asm__ __volatile__(					\
 			".set\tmips64\n\t"				\

  parent reply	other threads:[~2007-07-26  3:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-12 12:26 Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available Gregory Haskins
2007-07-12 13:09 ` Ingo Molnar
2007-07-13  6:25   ` Peter Williams
2007-07-13  6:52     ` Thomas Gleixner
2007-07-13  8:43     ` Gene Heskett
2007-07-13  9:42       ` Thomas Gleixner
2007-07-14  0:27       ` Peter Williams
2007-07-14  0:52         ` Gene Heskett
2007-07-26  1:24   ` Peter Williams [this message]
2007-07-26  7:36     ` Minor errors in 2.6.23-rc1-rt2 series Ingo Molnar
2007-08-06  1:29   ` Possible error in 2.6.23-rc2-rt1 series Peter Williams
2007-08-06  5:42     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A7F7BE.1030100@bigpond.net.au \
    --to=pwil3058@bigpond.net.au \
    --cc=DBahi@novell.com \
    --cc=MKohari@novell.com \
    --cc=SDietrich@novell.com \
    --cc=abogani@texware.it \
    --cc=dsaxena@plexity.net \
    --cc=dwalker@mvista.com \
    --cc=ghaskins@novell.com \
    --cc=jim.houston@ccur.com \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.