All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Michael Wu <flamingice@sourmilk.net>,
	James Ketrenos <jketreno@linux.intel.com>,
	Zhu Yi <yi.zhu@intel.com>
Subject: Re: driver bugs with changed mac address
Date: Wed, 25 Jul 2007 22:21:41 -0400	[thread overview]
Message-ID: <46A80535.7060301@gentoo.org> (raw)
In-Reply-To: <1182333938.3714.53.camel@johannes.berg>

Johannes Berg wrote:
> In zd1211, we start with hwaddr = dev->wiphy->perm_addr which isn't
> correct either, for a pure monitor mode we want to start with a zero mac
> addr to avoid acking packets. Also, zd1211rw will end up having a NULL
> hwaddr when a monitor interface is added, most likely segfaulting in
> zd_write_mac_addr then.

Sorry for the delay in getting to this.

Looking at this now, the behaviour you describe is not what happens. 
When I bring up an interface set to monitor mode, zd_mac_add_interface() 
gets called with a non-NULL mac address, the actual MAC of the device. 
So, when zd_mac_open gets called soon after, it calls zd_write_mac_addr 
with a non-NULL address, so it succeeds as normal.

Should I ignore the above and just set an all-zero MAC in the hardware 
when a monitor interface is brought up? (setting all-zero will disable acks)

Thanks,
Daniel


  parent reply	other threads:[~2007-07-26  2:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-20 10:05 driver bugs with changed mac address Johannes Berg
2007-06-20 21:52 ` Michael Buesch
2007-07-26  2:21 ` Daniel Drake [this message]
2007-07-26 15:39   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A80535.7060301@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=flamingice@sourmilk.net \
    --cc=jketreno@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.