Re: [PATCH] load_pdptrs cleanups

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Rusty Russell wrote:
> load_pdptrs can be handed an invalid cr3, and it should not oops.
> This can happen because we injected #gp in set_cr3() after we set
> vcpu->cr3 to the invalid value, or from kvm_vcpu_ioctl_set_sregs(), or
> possibly (?) memory configuration changes after the guest did
> set_cr3().
>
> We should also copy the pdpte array once, before checking and
> assigning, otherwise an SMP guest can potentially alter the values
> between the check and the set.
>
> Finally one nitpick: ret = 1 should be done as late as possible: this
> allows GCC to check for unset "ret" should the function change in
> future.
>
>   

Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/