All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] adt7470: Update sensors periodically via
Date: Thu, 26 Jul 2007 07:49:26 +0000	[thread overview]
Message-ID: <46A85206.7010402@hhs.nl> (raw)
In-Reply-To: <20070726010421.GM19586@tree.beaverton.ibm.com>

Darrick J. Wong wrote:
> On Wed, Jul 25, 2007 at 06:19:22PM -0700, Juerg Haefliger wrote:
>> Hi Darrick,
>>
>> Why using a workqueue at all? Can't you just run a timer and do the
>> update when it expires and restart the timer?
> 
> Currently, I use mutexes (and msleep) which require the ability to
> sleep.  Timers can't sleep because they are implemented as a softirq.
> That said, I think the solution is to have two workqueue items--one to
> start the read and another to run after the temperature sensors have
> been read.  The delays for both can be handled via schedule_delayed_work().
> It could be done with two timers and spinlocks, but ... yuck.
>

Or we could decide that we can live with the current 1 second + blocking of 
userspace apps, that is an option we should seriously consider too if this 
becomes ugly.

Regards,

hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-07-26  7:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26  1:04 [lm-sensors] [PATCH] adt7470: Update sensors periodically via timer Darrick J. Wong
2007-07-26  1:08 ` [lm-sensors] [PATCH] adt7470: Update sensors periodically via Darrick J. Wong
2007-07-26  1:19 ` Juerg Haefliger
2007-07-26  7:30 ` Darrick J. Wong
2007-07-26  7:49 ` Hans de Goede [this message]
2007-07-26 15:08 ` Juerg Haefliger
2007-07-26 16:57 ` Darrick J. Wong
2007-07-26 16:58 ` Hans de Goede
2007-07-26 20:03 ` Philip Pokorny
2007-07-29 19:18 ` Mark M. Hoffman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A85206.7010402@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.