Re: [PATCH 6/21] advansys: Move to scsi hotplug initialisation model

[Jeff Garzik <jeff@garzik.org>]

Matthew Wilcox wrote:
> On Thu, Jul 26, 2007 at 07:01:12PM +0100, Christoph Hellwig wrote:
>> On Thu, Jul 26, 2007 at 01:22:42PM -0400, Matthew Wilcox wrote:
>>>  - Switch from scsi_register/scsi_unregister to scsi_host_alloc,
>>>    scsi_add_host, scsi_scan_host and scsi_host_put.
>>>  - Rename the scsi_host_template to advansys_template
>>>  - Move the memory freeing on error from advansys_wide_init_chip()
>>>    back into advansys_board_found() as we need to free it if
>>>    scsi_add_host() returns an error.
>> If you switch to new style allocation please also remove ->detect and
>> ->release.  We don't really want half-conversions to the new model.
> 
> That happened in patch 4.

Incorrect.  It happened in "convert to pci_register_driver interface", 
42a06cfdd19a436047fef419d9b621c917118e3c

And Christoph is right -- ->detect and ->release should disappear in the 
same commit that you upgrade to the new scsi host model -- and stop 
including scsi_module.c -- otherwise your patch is incomplete (and 
broken WRT git-bisect producing a working driver at each point).

Look at the relevant code in scsi_module.c:

         sht->detect(sht);
         if (list_empty(&sht->legacy_hosts))
                 return -ENODEV;

If you are not using the old scsi_register() stuff, you are not 
populating sht->legacy_hosts, and your module load will fail.

	Jeff