diff for duplicates of <46A9CF66.90108@sophics.cz> diff --git a/a/1.txt b/N1/1.txt index 672181d..d40df35 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,11 +2,11 @@ Yoann Padioleau wrote: > When comparing a pointer, it's clearer to compare it to NULL than to 0. > stram_start = phys_to_virt(0); -> - kernel_in_stram = (stram_start = 0); -> + kernel_in_stram = (stram_start = NULL); +> - kernel_in_stram = (stram_start == 0); +> + kernel_in_stram = (stram_start == NULL); stram_start is more like an offset than pointer, IMHO. And 0 is a valid -offset. The "=NULL" does not make much sense in this particular case. +offset. The "==NULL" does not make much sense in this particular case. NULL is usually used when checking for an uninitialized pointer, right? Petr diff --git a/a/content_digest b/N1/content_digest index f394b66..1480726 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0200707270944.LAA17213@ifs.emn.fr\0" "From\0Petr Stehlik <pstehlik@sophics.cz>\0" "Subject\0Re: [PATCH 08/68] 0 -> NULL, for arch/m68k\0" - "Date\0Fri, 27 Jul 2007 10:56:38 +0000\0" + "Date\0Fri, 27 Jul 2007 12:56:38 +0200\0" "To\0Yoann Padioleau <padator@wanadoo.fr>\0" "Cc\0kernel-janitors@vger.kernel.org" geert@linux-m68k.org @@ -15,13 +15,13 @@ "> When comparing a pointer, it's clearer to compare it to NULL than to 0.\n" "\n" "> \tstram_start = phys_to_virt(0);\n" - "> -\tkernel_in_stram = (stram_start = 0);\n" - "> +\tkernel_in_stram = (stram_start = NULL);\n" + "> -\tkernel_in_stram = (stram_start == 0);\n" + "> +\tkernel_in_stram = (stram_start == NULL);\n" "\n" "stram_start is more like an offset than pointer, IMHO. And 0 is a valid \n" - "offset. The \"=NULL\" does not make much sense in this particular case. \n" + "offset. The \"==NULL\" does not make much sense in this particular case. \n" "NULL is usually used when checking for an uninitialized pointer, right?\n" "\n" Petr -12ae109a8ee953b1371aa03dce2cb9a25553e32dbedc4d0dfe99c3d9ab69f57f +d987cc15288b470a28eb47a4ca75277a3396e8200648c04ad866df13ec94f5ca
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.