Message-ID: <46A68977.50800@garzik.org> Date: Tue, 24 Jul 2007 19:21:27 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070719) MIME-Version: 1.0 To: Russell King CC: akpm@linux-foundation.org, mm-commits@vger.kernel.org, ambx1@neo.rr.com, bjorn.helgaas@hp.com, lenb@kernel.org, mjg59@srcf.ucam.org, sebastien.dugue@bull.net Subject: Re: + revert-x86-serial-convert-legacy-com-ports-to-platform-devices.patch added to -mm tree References: <200707241810.l6OIABWK026108@imap1.linux-foundation.org> <20070724210557.GA22165@flint.arm.linux.org.uk> <46A66C5A.6050305@garzik.org> <20070724213037.GC22165@flint.arm.linux.org.uk> <46A6774F.5050505@garzik.org> <20070724221052.GE22165@flint.arm.linux.org.uk> In-Reply-To: <20070724221052.GE22165@flint.arm.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Russell King wrote: > So we shouldn't even try to remove the legacy "legacy port" probing in > the serial driver like other platforms have done, which this patch minus > those bits I mentioned actually achieves? Move [to a new driver / location in tree]? Sure. As long as there are no probe order issues, module naming issues (I note distinct lack of MODULE_ALIAS for example) or other transitions issues. Remove? Definitely not. Even if we apply your suggested solution, updates are still needed: * fix kernel-parameters.txt * address transition issues related to module naming. other transition issues? has anybody even given this any thought? * no apparent module unload support (regression or just a bug?) * add docs for x86/x86-64 users (or point to docs in the source). Overall this was a highly "stealthy" change over to the new platform driver, without much notice at all. Not optimum, for a popular device on Linux's most popular platform. I have no complaints about platform_device direction, certainly. But this particular commit was incomplete, poorly described, and broke decade+ behavior. Jeff