All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Russell King" <rmk@arm.linux.org.uk>,
	"Adam Belay" <ambx1@neo.rr.com>, "Len Brown" <lenb@kernel.org>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Sébastien Dugué" <sebastien.dugue@bull.net>,
	"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] x86, serial: always probe for legacy COM ports
Date: Fri, 27 Jul 2007 16:21:55 -0400	[thread overview]
Message-ID: <46AA53E3.5080501@garzik.org> (raw)
In-Reply-To: <200707271411.42253.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> On Friday 27 July 2007 12:05:51 pm Jeff Garzik wrote:
>> This is still incomplete, as repeatedly stated.  Here is the email, again.

> OK, uncle!  I'll work on your helpful advice (thanks for that), but
> it feels too risky for this stage of 2.6.23.  Maybe I can come up with
> something for a future release.

The changeset in the kernel is too risky _without_ the changes I described.

Hence the repeated use of the word "incomplete."

* The patch has transition issues, when you shuffle users from one 
device driver to another.  Existing change should not be deployed 
without ensuring breakage is unlikely.

* The new driver is missing module unload support.  Existing change 
should not be deployed without this.

* DOCUMENT the user visible changes.  Existing change should not be 
deployed without this.

	Jeff




  reply	other threads:[~2007-07-27 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27 17:58 [patch] x86, serial: always probe for legacy COM ports Bjorn Helgaas
2007-07-27 18:05 ` Jeff Garzik
2007-07-27 20:11   ` Bjorn Helgaas
2007-07-27 20:21     ` Jeff Garzik [this message]
2007-07-27 20:26       ` Bjorn Helgaas
2007-07-27 20:35         ` Andrew Morton
2007-07-27 20:49         ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46AA53E3.5080501@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ambx1@neo.rr.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=sebastien.dugue@bull.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.