From: Jeff Garzik <jeff@garzik.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] SCSI bug fixes for 2.6.23-rc1
Date: Sun, 29 Jul 2007 21:04:11 -0400 [thread overview]
Message-ID: <46AD390B.2080400@garzik.org> (raw)
In-Reply-To: <1185756759.3434.19.camel@localhost.localdomain>
James Bottomley wrote:
> msleep_interruptible -> ssleep is a
> change with zero practical impact for this driver,
eh, how do you figure?
A signal can clearly cause the abort-related functions to delay far
shorter than the driver wishes.
The msleep_interruptible() in arcmsr_wait_msgint_ready() probably isn't
fatal -- unless it's there to ensure the hardware isn't pounded -- but
again, a signal can cause a CPU-wasting busy loop that could last for
quite a while (in CPU terms).
Jeff
next prev parent reply other threads:[~2007-07-30 1:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 14:49 [GIT PATCH] SCSI bug fixes for 2.6.23-rc1 James Bottomley
2007-07-29 22:51 ` Jeff Garzik
2007-07-30 0:52 ` James Bottomley
2007-07-30 1:04 ` Jeff Garzik [this message]
2007-07-30 2:01 ` James Bottomley
2007-07-30 2:14 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AD390B.2080400@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.