J. Bruce Fields wrote: > On Sat, Jul 28, 2007 at 05:50:24PM -0400, Chuck Lever wrote: >> Mostly comment clarification. Also replace some naked undocumented >> integers with macros, and make getport() static. >> @@ -153,25 +157,30 @@ unsigned short getport(struct sockaddr_in *saddr, unsigned long prog, >> return 0; >> } >> >> - switch (prot) { >> + switch (proto) { >> case IPPROTO_UDP: >> clnt = clntudp_bufcreate(saddr, >> - PMAPPROG, PMAPVERS, TIMEOUT, &socket, >> - UDPMSGSIZE, UDPMSGSIZE); >> + PMAPPROG, PMAPVERS, >> + RETRY_TIMEOUT, &socket, >> + RPCSMALLMSGSIZE, >> + RPCSMALLMSGSIZE); >> break; >> case IPPROTO_TCP: >> - clnt = clnttcp_create(saddr, >> - PMAPPROG, PMAPVERS, &socket, 50, 500); >> + clnt = clnttcp_create(saddr, PMAPPROG, PMAPVERS, &socket, >> + RPCSMALLMSGSIZE, RPCSMALLMSGSIZE); > > Did you mean to change those final two arguments? (They were different > before, then they're the same after.) They now match the code in support/nfs/conn.c:clnt_ping().