All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: rdunlap@xenotime.net, jschopp@austin.ibm.com,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch.pl false positive on exported pointers
Date: Mon, 30 Jul 2007 10:34:07 +0100	[thread overview]
Message-ID: <46ADB08F.3060601@shadowen.org> (raw)
In-Reply-To: <e9c3a7c20707290928r53bf2530ue02c5e1d4f03be46@mail.gmail.com>

Dan Williams wrote:
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #563: FILE: drivers/scsi/iioc34x/iioc34x_sas.c:58:
> +EXPORT_SYMBOL(iioc34x_transport_template);
> 
> drivers/scsi/iioc34x/iioc34x_sas.c:57
> struct scsi_transport_template *iioc34x_transport_template;
> EXPORT_SYMBOL(iioc34x_transport_template);
> 
> I suspect the script wants:
> EXPORT_SYMBOL(*iioc34x_transport_template);
> ...but that does not compile.

Thanks for the report.  Will look into this for the next update.

-apw

      reply	other threads:[~2007-07-30  9:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-29 16:28 checkpatch.pl false positive on exported pointers Dan Williams
2007-07-30  9:34 ` Andy Whitcroft [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46ADB08F.3060601@shadowen.org \
    --to=apw@shadowen.org \
    --cc=dan.j.williams@intel.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.