Re: Porting the RTSP module to 2.6.22

[Patrick McHardy <kaber@trash.net>]

Michael Guntsche wrote:
> Answering my own post.
> I already fixed the obvious mistake I made.
> On Jul 29, 2007, at 22:12, Michael Guntsche wrote:
> <snip>
> 
>> I changed this to
>>
>> static void
>> get_skb_tcpdata(struct sk_buff** skb, char** pptcpdata, uint* 
>> ptcpdatalen)
>> {
>>     struct iphdr*   iph  = ip_hdr(*skb);
>>     struct tcphdr*  tcph = (void *)iph + iph->ihl*4;
>>
>>     *pptcpdata = (char*)tcph + tcph->doff*4;
>>     *ptcpdatalen = ((char*)skb->h.raw + skb->len) - *pptcpdata;
>> }
>>
> 
> Of course there is no need to change skb.
> Sorry for not checking this before sending the first E-Mail.
> 
> static void
> get_skb_tcpdata(struct sk_buff* skb, char** pptcpdata, uint*  ptcpdatalen)
> {
>     struct iphdr*   iph  = ip_hdr(skb);
>     struct tcphdr*  tcph = (void *)iph + iph->ihl*4;
> 
>     *pptcpdata = (char*)tcph + tcph->doff*4;
>     *ptcpdatalen = ((char*)skb->h.raw + skb->len) - *pptcpdata;
> }
> 
> The problem remains though that the "h" member is no longer existing.


That shouldn't be a problem since netfilter modules should basically
never use it anyway since its only valid for locally generated packets.
Use Jan's suggestion (or look at other modules) and skb_header_pointer.