All of lore.kernel.org
 help / color / mirror / Atom feed
From: Songmao Tian <tiansm@lemote.com>
To: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: A blind patch:)
Date: Mon, 30 Jul 2007 23:32:44 +0800	[thread overview]
Message-ID: <46AE049C.6040500@lemote.com> (raw)

commit 5fabf601a53079c182d5c25f6e850d6a7bd48988 is broken. since the 
regptr is disappeared in the signature of the function, I think the 
regptr is useless.


diff --git a/arch/mips/kernel/unaligned.c b/arch/mips/kernel/unaligned.c
index bbf20ce..1b94eef 100644
--- a/arch/mips/kernel/unaligned.c
+++ b/arch/mips/kernel/unaligned.c
@@ -281,9 +281,7 @@ static void emulate_load_store_insn(struct pt_regs 
*regs,
             : "r" (addr), "i" (-EFAULT));
         if (res)
             goto fault;
-        *regptr = &regs->regs[insn.i_format.rt];
         compute_return_epc(regs);
-        *regptr = value;
         break;
 #endif /* CONFIG_64BIT */
 
@@ -324,9 +322,7 @@ static void emulate_load_store_insn(struct pt_regs 
*regs,
             : "r" (addr), "i" (-EFAULT));
         if (res)
             goto fault;
-        *regptr = &regs->regs[insn.i_format.rt];
         compute_return_epc(regs);
-        *regptr = value;
         break;
 #endif /* CONFIG_64BIT */
 

             reply	other threads:[~2007-07-30 15:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30 15:32 Songmao Tian [this message]
2007-07-30 17:18 ` A blind patch:) Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46AE049C.6040500@lemote.com \
    --to=tiansm@lemote.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.