From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by ozlabs.org (Postfix) with ESMTP id 110EADDED0 for ; Tue, 31 Jul 2007 02:38:14 +1000 (EST) Message-ID: <46AE13D0.7060902@intel.com> Date: Mon, 30 Jul 2007 09:37:36 -0700 From: "Kok, Auke" MIME-Version: 1.0 To: Jan-Bernd Themann Subject: Re: [PATCH 3/4][RFC] ehea: LRO support References: <200707301724.49829.ossthema@de.ibm.com> In-Reply-To: <200707301724.49829.ossthema@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Thomas Klein , Jeff Garzik , Jan-Bernd Themann , netdev , linux-kernel , linux-ppc , Christoph Raisch , Marcus Eder , Andrew Gallatin , Stefan Roscher , David Miller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Jan-Bernd Themann wrote: > Added LRO support using the "SKB aggregate" interface > > Signed-off-by: Jan-Bernd Themann > > --- > drivers/net/ehea/ehea.h | 9 ++++- > drivers/net/ehea/ehea_ethtool.c | 15 +++++++ > drivers/net/ehea/ehea_main.c | 82 +++++++++++++++++++++++++++++++++++--- > 3 files changed, 98 insertions(+), 8 deletions(-) > +module_param(use_lro, int, 0); > +module_param(lro_max_aggr, int, 0); this should obviously (and Stephen H. probably agrees) be implemented in ethtool instead, and opens up the question as to what changes we need to add to ethtool. .. Auke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967435AbXG3Qib (ORCPT ); Mon, 30 Jul 2007 12:38:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S967074AbXG3QiQ (ORCPT ); Mon, 30 Jul 2007 12:38:16 -0400 Received: from mga03.intel.com ([143.182.124.21]:35451 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967008AbXG3QiO (ORCPT ); Mon, 30 Jul 2007 12:38:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.19,199,1183359600"; d="scan'208";a="256490653" Message-ID: <46AE13D0.7060902@intel.com> Date: Mon, 30 Jul 2007 09:37:36 -0700 From: "Kok, Auke" User-Agent: Thunderbird 2.0.0.4 (X11/20070623) MIME-Version: 1.0 To: Jan-Bernd Themann CC: netdev , Christoph Raisch , Jan-Bernd Themann , linux-kernel , linux-ppc , Marcus Eder , Thomas Klein , Stefan Roscher , Jeff Garzik , David Miller , Andrew Gallatin Subject: Re: [PATCH 3/4][RFC] ehea: LRO support References: <200707301724.49829.ossthema@de.ibm.com> In-Reply-To: <200707301724.49829.ossthema@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 30 Jul 2007 16:38:11.0215 (UTC) FILETIME=[0461A9F0:01C7D2C8] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jan-Bernd Themann wrote: > Added LRO support using the "SKB aggregate" interface > > Signed-off-by: Jan-Bernd Themann > > --- > drivers/net/ehea/ehea.h | 9 ++++- > drivers/net/ehea/ehea_ethtool.c | 15 +++++++ > drivers/net/ehea/ehea_main.c | 82 +++++++++++++++++++++++++++++++++++--- > 3 files changed, 98 insertions(+), 8 deletions(-) > +module_param(use_lro, int, 0); > +module_param(lro_max_aggr, int, 0); this should obviously (and Stephen H. probably agrees) be implemented in ethtool instead, and opens up the question as to what changes we need to add to ethtool. .. Auke