diff for duplicates of <46AF28CF.6000302@student.ltu.se> diff --git a/a/1.txt b/N1/1.txt index a3eb6fd..c750075 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,8 +4,8 @@ Jan Engelhardt wrote: >> On Fri, Jul 27, 2007 at 11:44:07AM +0200, Yoann Padioleau wrote: >> >>> buf = alloc_safe_buffer(device_info, ptr, size, dir); ->>> - if (buf = 0) { ->>> + if (buf = NULL) { +>>> - if (buf == 0) { +>>> + if (buf == NULL) { >>> >> if (!buf) >> surely... @@ -14,7 +14,7 @@ Jan Engelhardt wrote: > Makes it look like it's used as a bool. > But the conditional checking for a pointer and a boolean is the same; 0 -= NULL = 'false' and the rest is valid/'true'. So IMHO it is a cleaner +== NULL == 'false' and the rest is valid/'true'. So IMHO it is a cleaner way to write it. But then again, some people like to abuse the '!' on "regular" variables. diff --git a/a/content_digest b/N1/content_digest index ff56766..f8c4adb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0Pine.LNX.4.64.0707271250020.12711@fbirervta.pbzchgretzou.qr\0" "From\0Richard Knutsson <ricknu-0@student.ltu.se>\0" "Subject\0Re: [PATCH 02/68] 0 -> NULL, for arch/arm\0" - "Date\0Tue, 31 Jul 2007 12:19:27 +0000\0" + "Date\0Tue, 31 Jul 2007 14:19:27 +0200\0" "To\0Jan Engelhardt <jengelh@computergmbh.de>\0" "Cc\0Al Viro <viro@ftp.linux.org.uk>" Yoann Padioleau <padator@wanadoo.fr> @@ -19,8 +19,8 @@ ">> On Fri, Jul 27, 2007 at 11:44:07AM +0200, Yoann Padioleau wrote:\n" ">> \n" ">>> \t\tbuf = alloc_safe_buffer(device_info, ptr, size, dir);\n" - ">>> -\t\tif (buf = 0) {\n" - ">>> +\t\tif (buf = NULL) {\n" + ">>> -\t\tif (buf == 0) {\n" + ">>> +\t\tif (buf == NULL) {\n" ">>> \n" ">> \t\tif (!buf)\n" ">> surely...\n" @@ -29,10 +29,10 @@ "> Makes it look like it's used as a bool.\n" "> \n" "But the conditional checking for a pointer and a boolean is the same; 0 \n" - "= NULL = 'false' and the rest is valid/'true'. So IMHO it is a cleaner \n" + "== NULL == 'false' and the rest is valid/'true'. So IMHO it is a cleaner \n" "way to write it. But then again, some people like to abuse the '!' on \n" "\"regular\" variables.\n" "\n" Richard Knutsson -3fd217f512f7c313841a06ecbd01176dae0739d1da8ea0080aede5bdeda5d37b +8c45b03b552d288a23eaa3d152b7ae44216ac848ce8e02fc9d4bc1ddb124ae19
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.