All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: jack@hawkeye.stone.uk.eu.org
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [Patch 14/16] Remove needless kmalloc casts in the zd1211rw drivers.
Date: Tue, 31 Jul 2007 10:18:45 -0400	[thread overview]
Message-ID: <46AF44C5.50102@gentoo.org> (raw)
In-Reply-To: <20070731125446.578465000@hawkeye.stone.uk.eu.org>

jack@hawkeye.stone.uk.eu.org wrote:
> Signed-off-by: Jack Stone <jack@hawkeye.stone.uk.eu.org>
> 
> CC: Daniel Drake <dsd@gentoo.org>

NAK: this patch adds a sparse warning
zd_chip.c:116:15: warning: implicit cast to nocast type

> ---
>  drivers/net/wireless/zd1211rw/zd_chip.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/drivers/net/wireless/zd1211rw/zd_chip.c
> ===================================================================
> --- a/drivers/net/wireless/zd1211rw/zd_chip.c
> +++ b/drivers/net/wireless/zd1211rw/zd_chip.c
> @@ -115,7 +115,7 @@ int zd_ioread32v_locked(struct zd_chip *
>  
>  	/* Allocate a single memory block for values and addresses. */
>  	count16 = 2*count;
> -	a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
> +	a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
>  		                   GFP_KERNEL);
>  	if (!a16) {
>  		dev_dbg_f(zd_chip_dev(chip),
> 


  reply	other threads:[~2007-07-31 14:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-31 12:53 [Patch 00/16] Remove unnecessary kmalloc casts jack
2007-07-31 12:53 ` [Patch 01/16] Remove unnecessary kmalloc casts from the cris arch jack
2007-08-01  1:06   ` Stefan Richter
2007-07-31 12:53 ` [Patch 02/16] Remove unnecessary kmalloc casts from the mips arch jack
2007-07-31 14:15   ` Christian Borntraeger
2007-07-31 15:15   ` Rene Herman
2007-07-31 12:53 ` [Patch 03/16] Remove unnecessary kmalloc casts from the powerpc arch jack
2007-07-31 12:53 ` [Patch 04/16] Remove unnecessary kmalloc casts from the sparc arch jack
2007-07-31 14:09   ` WANG Cong
2007-07-31 12:53 ` [Patch 05/16] Remove unnecessary kmalloc casts in the drivers subdirectory jack
2007-08-01  0:53   ` Stefan Richter
2007-07-31 12:53 ` [Patch 06/16] This removes unnecessary kmalloc casts and corrects a test for kmalloc failure jack
2007-07-31 14:17   ` Christian Borntraeger
2007-07-31 12:53 ` [Patch 07/16] Remove unnecessary kmalloc casts in the mtd drivers jack
2007-07-31 12:53 ` [Patch 08/16] Remove unnecessary kmalloc casts in the parisc drivers jack
2007-07-31 14:06   ` Christian Borntraeger
2007-07-31 12:53 ` [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem jack
2007-07-31 13:53   ` Christian Borntraeger
2007-07-31 14:30     ` Satyam Sharma
2007-07-31 14:46       ` WANG Cong
2007-07-31 16:05         ` Satyam Sharma
2007-07-31 16:10         ` Greg KH
2007-07-31 16:20           ` Andreas Schwab
2007-07-31 17:47             ` Greg KH
2007-07-31 18:06               ` Satyam Sharma
2007-08-01  4:02               ` Paul Mackerras
2007-07-31 20:19     ` David Miller
2007-07-31 12:53 ` [Patch 10/16] Remove unnecessary kmalloc casts in the irda drivers jack
2007-07-31 12:53 ` [Patch 11/16] Remove unnecessary kmalloc casts in drivers/net jack
2007-07-31 14:16   ` Christian Borntraeger
2007-07-31 12:53 ` [Patch 12/16] Remove unnecessary kmalloc casts in the libertas drivers jack
2007-07-31 12:53 ` [Patch 13/16] Remove needless kmalloc casts in the wireless drivers jack
2007-07-31 12:53 ` [Patch 14/16] Remove needless kmalloc casts in the zd1211rw drivers jack
2007-07-31 14:18   ` Daniel Drake [this message]
2007-08-01  1:11     ` Stefan Richter
2007-08-01  2:09       ` Daniel Drake
2007-07-31 12:53 ` [Patch 15/16] Remove unnecesary kmalloc casts in the scsi drivers jack
2007-07-31 14:20   ` James Bottomley
2007-07-31 12:53 ` [Patch 16/16] Remove unnecessary kmalloc casts in the jfs filesystem jack
2007-07-31 13:14   ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46AF44C5.50102@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=jack@hawkeye.stone.uk.eu.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.